PB-1969 Feedback to 3D from ltrea #patch #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltclm
approved these changes
Oct 8, 2025
asteiner-swisstopo
requested changes
Oct 21, 2025
Contributor
asteiner-swisstopo
left a comment
asteiner-swisstopo
left a comment
There was a problem hiding this comment.
Nice to have more up-to-date examples 👍 I suggest we still fix the typos in the new text before merging.
docs/3d-tiles.md
Outdated
|
|
||
| <ApiCodeBlock url="https://3d.geo.admin.ch/<LayerName>/<Version>/<Time>/tileset.json" method="GET" /> | ||
|
|
||
| f you always want the most rectent cesium tiles, you can leave `/<Time>` away in the path towards `tileset.json`. |
Contributor
There was a problem hiding this comment.
How about adding this to the Time parameter in the parameter table below?
If so, I would propose the following shorter phrasing:
If you omit this parameter, the most recent tile is returned.
Same further below.
asteiner-swisstopo
changed the title
rebert
force-pushed
the
ltrea-feedback-in-3D
branch
from
c07ce0c to
fc04386
Compare
rebert
force-pushed
the
ltrea-feedback-in-3D
branch
2 times, most recently
from
d52ada6 to
561e3ad
Compare
rebert
force-pushed
the
ltrea-feedback-in-3D
branch
from
561e3ad to
eb9a2f5
Compare
asteiner-swisstopo
approved these changes
Oct 22, 2025
Contributor
asteiner-swisstopo
left a comment
asteiner-swisstopo
left a comment
There was a problem hiding this comment.
Still a tiny typo to fix, otherwise all good. Thanks 👍
docs/3d-tiles.md
Outdated
| | Parameter | Example | Description | | ||
| | --------------- | -------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | Time (optional) | 20201203 | Date of tile generation in (ISO-8601). | | ||
| | Time (optional) | 20250728 | Date of tilegeneration in ISO-8601(YYYYMMDD). If you omit this parameter, the most recent tile is returned. | |
Contributor
There was a problem hiding this comment.
Nitpick: Has some wrong white spaces.
Should be:
Date of tile generation in ISO-8601 (YYYYMMDD).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link